Fix FSDirectory.open API [LUCENE-5663]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
Spinoff from #6720
> This does not use NIOFSDir! open() is a static factory method on FSDirectory, just inherited to NIOFSDirectory\.
I think its confusing we have this method on FSDirectory, so its visible in subclasses. We should at least consider doing this in another way so its not confusing.
---
Migrated from [LUCENE-5663](https://issues.apache.org/jira/browse/LUCENE-5663) by Robert Muir (@rmuir), updated May 19 2014
Contributor guide
Research direction
Review the FSDirectory.open API and the discussion spun off in #6720, including the migrated LUCENE-5663 context. Determine a concrete way to avoid confusing inherited visibility in subclasses; the issue does not name files or tests, and completion depends on an agreed API design.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100