StringHelper should check for empty string of "tests.seed" system property [LUCENE-5645]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
As of #6666 (committed to v4.8), StringHelper will initialize GOOD_FAST_HASH_SEED based on the system property "tests.seed" if it is set. Unfortunately it doesn't do an empty-string check, and it's common at least in my setup that copies Lucene's maven pom.xml that the string will be empty unless I set it on the command line. FWIW Randomized Testing does do an empty-string check.
---
Migrated from [LUCENE-5645](https://issues.apache.org/jira/browse/LUCENE-5645) by David Smiley (@dsmiley), 1 vote, updated May 09 2016
Attachments: [LUCENE-5645_StringHelper_empty_tests_seed_condition.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-5645/LUCENE-5645_StringHelper_empty_tests_seed_condition.patch)
Contributor guide
Assessment
This issue has not been assessed yet.