apache / apache/lucene

Optimize NumericAttributeFactory [LUCENE-5643]

Open
#6,705 2 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major module:analysis type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

Followup from #6700: NumericTokenStream has its own factory, wrapping AttributeFactory.DEFAULT_ATTRIBUTE_FACTORY.

Currently it gets no speedup from the change, but I think it could (I saw speedups for even StringField from that change)

It has 3 attributes: NumericTermAttribute, posIncr, and type. Maybe the NumericTermAttributeImpl should also implement posIncr and type?

---
Migrated from [LUCENE-5643](https://issues.apache.org/jira/browse/LUCENE-5643) by Robert Muir (@rmuir)
Attachments: [LUCENE-5643.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-5643/LUCENE-5643.patch)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.