apache / apache/lucene

Re-enable MockDirectoryWrapper's unref'd file checking [LUCENE-5576]

Open
#6,638 0 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

In #6636 we had to turn this off to fix a bug whereby closing an NRT reader could delete files that it should not.

---
Migrated from [LUCENE-5576](https://issues.apache.org/jira/browse/LUCENE-5576) by Michael McCandless (@mikemccand)

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #6636 and the MockDirectoryWrapper unref'd file-checking behavior described here. Investigate the NRT reader-closing regression that prompted the check to be disabled; done means the checking is re-enabled without allowing reader closure to delete files that are still needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.