apache / apache/lucene

ShingleAnalyzerWrapper should expose the delegated analyzer as a public final [LUCENE-5406]

Open
#6,469 5 comments 0 reactions 1 assignee Claimed by @gsingers View on GitHub
legacy-jira-fix-version:4.9 legacy-jira-fix-version:6.0 legacy-jira-priority:Major type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

I'm sometimes given a ShingleAnalyzerWrapper that I would like to change the shingle size on, so I need to create a new instance. However, I don't always know what the underlying analyzer is and I can't access it b/c it is a protected method on a final class.

The solution here is to make the getAnalyzer method public final for the ShingleAnalyzerWrapper.

---
Migrated from [LUCENE-5406](https://issues.apache.org/jira/browse/LUCENE-5406) by Grant Ingersoll (@gsingers), updated May 09 2016

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.