Don't use recursion in DisjunctionSumScorer.countMatches [LUCENE-5279]
Open
legacy-jira-priority:Major
type:enhancement
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
I noticed the TODO in there, to not use recursion, so I fixed it to just use a private queue ...
---
Migrated from [LUCENE-5279](https://issues.apache.org/jira/browse/LUCENE-5279) by Michael McCandless (@mikemccand)
Attachments: [LUCENE-5279.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-5279/LUCENE-5279.patch)
Contributor guide
Research direction
Locate DisjunctionSumScorer.countMatches and its recursion-related TODO, then review the attached LUCENE-5279.patch for the intended change. Confirm that the recursive traversal is replaced with a private queue and run the relevant scorer tests to verify matching behavior is unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100