apache / apache/lucene

DISI.iterator() should never return null. [LUCENE-5117]

Open
#6,181 7 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

If you have a Filter, you have to check for null twice: Filter.getDocIDSet() can return a null DocIDSet, and then DocIDSet.iterator() can return a null iterator.

There is no reason for this: I think iterator() should never return null (consistent with terms/postings apis).

---
Migrated from [LUCENE-5117](https://issues.apache.org/jira/browse/LUCENE-5117) by Robert Muir (@rmuir), updated Oct 23 2014

Contributor guide

Open the contributing guide

Research direction

Start by locating DISI.iterator(), Filter.getDocIDSet(), and DocIDSet.iterator(), then inspect their implementations and existing tests. Confirm how null DocIDSets and iterators are handled across the search APIs; done means iterator() no longer returns null and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.