apache / apache/lucene

Refactor TestGrouping.java to break TestRandom into separate tests [LUCENE-5065]

Open
#6,129 1 comment 0 reactions 0 assignees View on GitHub
affects-version:4.3.1 legacy-jira-priority:Minor module:grouping type:test
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

lucene/grouping/src/test/org/apache/lucene/search/grouping
TestGrouping.java combines multiple tests inside of one test: TestRandom().
This makes it difficult to understand or for new users to use the TestGrouping.java as an entry to understanding grouping functionality.

Either break TestRandom into separate tests or add small separate tests for the most important parts of TestRandom.

---
Migrated from [LUCENE-5065](https://issues.apache.org/jira/browse/LUCENE-5065) by Tom Burton-West, updated Jun 23 2013

Contributor guide

Open the contributing guide

Research direction

Start with lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java and inspect the combined TestRandom() test. Identify the important grouping behaviors covered there and separate them into focused tests or add small tests for the most important parts. Done means TestGrouping.java is easier to understand as an entry point while preserving the existing coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.