apache / apache/lucene

AssertingIndexSearcher should do basic QueryUtils/etc checks on every query [LUCENE-4934]

Open
#5,998 10 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:test
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

We can start with QueryUtils.check(query): which does some basic hashcode/equals checks.

Ideally we'd strengthen the checks as we fix problems: e.g. add explanations verifications (checkExplanations) and then finally the more intense check() that does more verifications with deleted docs/next/advance.

---
Migrated from [LUCENE-4934](https://issues.apache.org/jira/browse/LUCENE-4934) by Robert Muir (@rmuir)
Attachments: [LUCENE-4934.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-4934/LUCENE-4934.patch) (versions: 4)

Contributor guide

Open the contributing guide

Research direction

Start by locating AssertingIndexSearcher and QueryUtils, then read how queries are executed and where QueryUtils.check(query) can be applied. Begin with the requested hashCode/equals checks on every query; completion should also reflect any explanation or deeper checks that the implementation scope adopts.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.