apache / apache/lucene

more *Ref bugs in copyXXXX (maybe appendXXXX tooo) [LUCENE-4714]

Open
#5,779 6 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

```Java
public void copyBytes(BytesRef other) {
- if (bytes.length - offset < other.length) {
+ if (length < other.length) {
```

I'll work up tests for all these classes

---
Migrated from [LUCENE-4714](https://issues.apache.org/jira/browse/LUCENE-4714) by Robert Muir (@rmuir)
Attachments: [LUCENE-4714.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-4714/LUCENE-4714.patch) (versions: 4)

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the BytesRef.copyBytes example and the attached LUCENE-4714.patch; identify the other *Ref copyXXXX and possible appendXXXX methods implicated. Add tests for each confirmed bounds bug and run the relevant Lucene tests to verify the fixes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.