apache / apache/lucene

Make LuceneTestCase.TEMP_DIR pkg-private [LUCENE-4414]

Open
#5,480 1 comment 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:task type:test
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

Tests using this could be asking for trouble: e.g. its just that particular test slave's directory and two tests could have a conflict and interfere with each other, or previous runs could affect the test, etc.

I think its better to always use a unique tempdir, e.g. _TestUtil.getTempDir(String)

---
Migrated from [LUCENE-4414](https://issues.apache.org/jira/browse/LUCENE-4414) by Robert Muir (@rmuir)

Contributor guide

Open the contributing guide

Research direction

Locate LuceneTestCase.TEMP_DIR and its test usages; read _TestUtil.getTempDir(String) first to understand the intended replacement. Update the affected tests so they no longer depend on the shared directory, make TEMP_DIR package-private, and verify the tests avoid conflicts from shared or previous-run files.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.