apache / apache/lucene

Builds should regenerate all generated sources [LUCENE-4335]

Open
#5,402 52 comments 0 reactions 1 assignee Claimed by @mikemccand View on GitHub
legacy-jira-priority:Major type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

We have more and more sources that are generated programmatically (query parsers, fuzzy levN tables from Moman, packed ints specialized decoders, etc.), and it's dangerous because developers may directly edit the generated sources and forget to edit the meta-source. It's happened to me several times ... most recently just after landing the BlockPostingsFormat branch.

I think we should re-gen all of these in our builds and fail the build if this creates a difference. I know some generators (eg JavaCC) embed timestamps and so always create mods ... we can leave them out of this for starters (or maybe post-process the sources to remove the timestamps) ...

---
Migrated from [LUCENE-4335](https://issues.apache.org/jira/browse/LUCENE-4335) by Michael McCandless (@mikemccand), updated Dec 08 2014
Attachments: [LUCENE-4335.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-4335/LUCENE-4335.patch) (versions: 3)
Linked issues:
- #6614

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.