apache / apache/lucene

Delegate to default thread factory in NamedThreadFactory [LUCENE-4281]

Open
#5,349 11 comments 0 reactions 0 assignees View on GitHub
affects-version:3.6.1 affects-version:4.0-BETA affects-version:6.0 legacy-jira-fix-version:4.9 legacy-jira-fix-version:6.0 legacy-jira-priority:Minor type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

currently we state that we yield the same behavior as Executors#defaultThreadFactory() but this behavior could change over time even if it is compatible. We should just delegate to the default thread factory instead of creating the threads ourself.

---
Migrated from [LUCENE-4281](https://issues.apache.org/jira/browse/LUCENE-4281) by Simon Willnauer (@s1monw), updated May 09 2016
Attachments: [LUCENE-4281.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-4281/LUCENE-4281.patch)

Contributor guide

Open the contributing guide

Research direction

Start by locating NamedThreadFactory and any tests covering its thread creation. Compare the current implementation with Executors#defaultThreadFactory() and verify that the requested delegation preserves the expected behavior; done when the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.