Implement better equals() on PostingsFormats where possible [LUCENE-4093]
Open
legacy-jira-priority:Major
module:core/index
type:bug
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
As of #5162, we use HashMap to deduplicate per-field configurations, but all PostingsFormats still implement Object.hashCode/equals.
This is fine, but it means more files etc could be created than are really necessary.
---
Migrated from [LUCENE-4093](https://issues.apache.org/jira/browse/LUCENE-4093) by Robert Muir (@rmuir)
Contributor guide
Research direction
Start by reviewing the HashMap deduplication introduced in #5162 and the PostingsFormats implementations to identify where value equality is meaningful. Determine the expected behavior for equivalent per-field configurations and add coverage for the affected cases; done means unnecessary file creation is reduced without changing distinct configurations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100