apache / apache/lucene

Lucene puts output of svnversion into a property even if svnversion failed [LUCENE-4073]

Open
#5,145 1 comment 0 reactions 0 assignees View on GitHub
affects-version:3.6 legacy-jira-priority:Major tool:build type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

We had a build issue today where Lucene was running svnversion which was failing (the reason for the failure itself is not particularly important.)

As a result, the error text output of running the command ended up in the svnversion property. The build later attempted to insert this into MANIFEST.MF which resulted in an invalid manifest file, causing the build to fail.

A related observation is that even if it works, the svnversion would be the version of our own repository, so the usefulness of it in the context of Lucene's version number is questionable anyway. It would be nice if the build could get the svn version number only if it was checked out from Lucene trunk.

---
Migrated from [LUCENE-4073](https://issues.apache.org/jira/browse/LUCENE-4073) by Trejkaz, updated Sep 08 2014
Environment:
```
Windows 7 x64, Cygwin for tools like svn
```

Linked issues:
- #6656

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.