apache / apache/lucene

TestRandomChains failure caused by incorrect delegation in CharReader/CharFilter/CharStream API [LUCENE-3990]

Open
#5,063 19 comments 0 reactions 1 assignee Claimed by @uschindler View on GitHub
legacy-jira-fix-version:4.9 legacy-jira-fix-version:6.0 legacy-jira-priority:Major module:analysis type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

100% reproduces for me:

2> NOTE: reproduce with: ant test -Dtests.class=\*.TestRandomChains -Dtests.method=testRandomChains -Dtests.seed=88CA02C2BB7B1DA -Dargs="-Dfile.encoding=UTF-8"

Running org.apache.lucene.analysis.core.TestRandomChains
FAILURE 7.22s | TestRandomChains.testRandomChains
> Throwable #1: java.lang.AssertionError: endOffset 1 expected:<7> but was:<8>
> at __randomizedtesting.SeedInfo.seed([88CA02C2BB7B1DA:356D894D6CA5AC1A]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:472)
> at org.apache.lucene.analysis.BaseTokenStreamTestCase.assertTokenStreamContents(BaseTokenStreamTestCase.java:165)
> at org.apache.lucene.analysis.BaseTokenStreamTestCase.checkAnalysisConsistency(BaseTokenStreamTestCase.java:662)
> at org.apache.lucene.analysis.BaseTokenStreamTestCase.checkRandomData(BaseTokenStreamTestCase.java:486)
> at org.apache.lucene.analysis.BaseTokenStreamTestCase.checkRandomData(BaseTokenStreamTestCase.java:429)
> at org.apache.lucene.analysis.core.TestRandomChains.testRandomChains(TestRandomChains.java:820)

The root cause of this is inconsequent override of several Reader methods in subclasses of CharFilter. We should fix this urgently, thanks to the random chains we found this bug.

---
Migrated from [LUCENE-3990](https://issues.apache.org/jira/browse/LUCENE-3990) by Steven Rowe (@sarowe), updated May 09 2016
Attachments: [analysis-common.tests-report.txt](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3990/analysis-common.tests-report.txt), [LUCENE-3990.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3990/LUCENE-3990.patch), [LUCENE-3990-CharFilterFix.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3990/LUCENE-3990-CharFilterFix.patch)
Linked issues:
- #4992

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.