apache / apache/lucene

Improve AllGroupsCollector implementations [LUCENE-3972]

Open
#5,045 17 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major module:grouping type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

I think that the performance of TermAllGroupsCollectorm, DVAllGroupsCollector.BR and DVAllGroupsCollector.SortedBR can be improved by using BytesRefHash to store the groups instead of an ArrayList.

---
Migrated from [LUCENE-3972](https://issues.apache.org/jira/browse/LUCENE-3972) by Martijn van Groningen (@martijnvg), updated Jul 16 2013
Attachments: [LUCENE-3972.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3972/LUCENE-3972.patch) (versions: 2)

Contributor guide

Open the contributing guide

Research direction

Locate the TermAllGroupsCollector, DVAllGroupsCollector.BR, and DVAllGroupsCollector.SortedBR implementations and inspect how they currently store groups in ArrayList. Compare that storage with the attached LUCENE-3972.patch and verify that group collection behavior is preserved while evaluating the proposed BytesRefHash-based performance improvement.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
performance, search
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.