DocValuesConsumer should implement closeable and release resource in close instead of during finish / flush [LUCENE-3689]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
DocValuesConsumer currently doesn't have a close method and releases its resources during finish / flush. This is confusing, makes debugging more complex and mixes concerns. DocValuesConsumer should impl. Closeable and users should release resources safely.
---
Migrated from [LUCENE-3689](https://issues.apache.org/jira/browse/LUCENE-3689) by Simon Willnauer (@s1monw), updated May 09 2016
Attachments: [LUCENE-3689.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3689/LUCENE-3689.patch)
Contributor guide
Research direction
Locate DocValuesConsumer and inspect how its resources are released during finish and flush. Read the attached LUCENE-3689.patch for the historical context, then trace users that create or finish it. Done means DocValuesConsumer is Closeable and resource release occurs safely in close rather than finish or flush.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- search
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100