apache / apache/lucene

Make DirectoryReader protected methods non-final [LUCENE-3497]

Open
#4,571 3 comments 0 reactions 0 assignees View on GitHub
affects-version:3.4 affects-version:4.0-ALPHA legacy-jira-priority:Minor module:core/index type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

DirectoryReader has protected methods that are overridden and made final. This is silly because it prevents other classes from overriding DirectoryReader. The methods are doOpenIfChanged(\*) and a handful of related variables that are private.

---
Migrated from [LUCENE-3497](https://issues.apache.org/jira/browse/LUCENE-3497) by Jason Rutherglen
Attachments: [LUCENE-3497.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3497/LUCENE-3497.patch)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.