apache / apache/lucene

Analysis Consumers should end and close any TokenStreams [LUCENE-3456]

Open
#4,530 14 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:task
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 6h
Merged PRs (30d)
86

Description

While converting consumers over to using reusableTokenStream, I notice many don't call end() or close() on TokenStreams.

Even if they are test TSs only created once, we should follow the defined usage pattern.

---
Migrated from [LUCENE-3456](https://issues.apache.org/jira/browse/LUCENE-3456) by Chris Male, updated Jan 30 2013
Parent: #4469
Attachments: [LUCENE-3456.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3456/LUCENE-3456.patch) (versions: 2)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.