apache / apache/lucene

FastVectorHighlighter ignores MultiPhraseQuery (and more) [LUCENE-3332]

Open
#4,405 4 comments 0 reactions 0 assignees View on GitHub
affects-version:3.3 affects-version:4.0-ALPHA legacy-jira-label:highlighting legacy-jira-priority:Minor module:highlighter type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

Similar to #1573.

Create a MultiPhraseQuery, use FastVectorHighlighter, you'll have no fragment.
Using PhraseQuery and/or Highlighter works, but not the previous combination.

---
Migrated from [LUCENE-3332](https://issues.apache.org/jira/browse/LUCENE-3332) by Olivier Favre (@ofavre)
Environment:
```
Tested against Lucene trunk revision 1149488 (4.0), but seen under Lucene 3.3 (tested through ElasticSearch 0.17.1, but the code is clear: this version, and surely other prior (3.1-3.2) are impacted)
```

Attachments: [TestMultiPhraseQueryHighlighting.java](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3332/TestMultiPhraseQueryHighlighting.java), [UsingCombinationAndFallback.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3332/UsingCombinationAndFallback.patch), [UsingFallback.patch](https://apache.github.io/lucene-jira-archive/attachments/LUCENE-3332/UsingFallback.patch)

Contributor guide

Open the contributing guide

Research direction

Start with the attached TestMultiPhraseQueryHighlighting.java and trace FastVectorHighlighter handling of MultiPhraseQuery, comparing it with the working PhraseQuery and Highlighter cases. Run the attached test against the affected Lucene versions; done means the MultiPhraseQuery produces a fragment rather than no output.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.