apache / apache/lucene

FST APIs should support CharsRef too [LUCENE-3145]

Open
#4,218 4 comments 0 reactions 0 assignees View on GitHub
legacy-jira-fix-version:4.9 legacy-jira-fix-version:6.0 legacy-jira-priority:Major type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The Builder API at heart is IntsRef, but we have sugar to pass in BytesRef, CharSequence, etc. We should add CharsRef too.

Likewise we have IntsRefFSTEnum, BytesRefFSTEnum; we should add CharsRef there.

Finally the static Util methods should accept CharsRef.

---
Migrated from [LUCENE-3145](https://issues.apache.org/jira/browse/LUCENE-3145) by Michael McCandless (@mikemccand), updated May 09 2016

Contributor guide

Open the contributing guide

Research direction

Locate the FST Builder API, IntsRefFSTEnum and BytesRefFSTEnum, and the static Util methods mentioned in the issue. Trace how existing BytesRef and CharSequence overloads are exposed, then verify that equivalent CharsRef support works across the Builder, enum, and Util APIs.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.