apache / apache/lucene

PrefixAndSuffixAwareTokenFilter code cleanup [LUCENE-3114]

Open
#4,187 0 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major module:analysis type:task
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

as noted on #4186, I think this tokenstream is difficult to review.

In my opinion just changing the 'private PrefixAwareTokenFilter suffix' to 'private PrefixAwareTokenFilter prefixAndSuffix' would work wonders.

---
Migrated from [LUCENE-3114](https://issues.apache.org/jira/browse/LUCENE-3114) by Robert Muir (@rmuir)

Contributor guide

Open the contributing guide

Research direction

Start by locating the PrefixAndSuffixAwareTokenFilter class and its private suffix field; the issue proposes renaming that field to prefixAndSuffix for reviewability. The payload names no test or file, so identify the class's relevant tests and verify they pass after the cleanup.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.