apache / apache/lucene

LUCENE-2372, LUCENE-2389 made it impossible to subclass core analyzers [LUCENE-3055]

Open
#4,128 5 comments 0 reactions 0 assignees View on GitHub
affects-version:3.1 legacy-jira-priority:Major module:analysis type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

#3448 and #3464 marked all analyzers as final. This makes ReusableAnalyzerBase useless, and makes it impossible to subclass e.g. StandardAnalyzer to make a small modification e.g. to tokenStream(). These issues don't indicate a new method of doing this. The issues don't give a reason except for design considerations, which seems a poor reason to make a backward-incompatible change

---
Migrated from [LUCENE-3055](https://issues.apache.org/jira/browse/LUCENE-3055) by Ian Soboroff (@isoboroff), updated Sep 25 2011

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the analyzer changes referenced in #3448 and #3464, then inspect ReusableAnalyzerBase and the core analyzer classes to understand the compatibility impact. The issue does not name files or tests, and completion depends on deciding and validating a supported subclassing approach for analyzers such as StandardAnalyzer.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.