IndexWriter should also warm flushed segments [LUCENE-2485]
- Dominant language
- Java
- Stars
- 3.6k
- Forks
- 1.4k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 88
Description
Spinoff of #3387.
You can now set a mergedSegmentWarmer on IW, which warms only newly merged segments.
But for consistency maybe we should change this to warm all new segments (ie, also flushed ones). We should rename it to something "setSegmentWarmer".
Really, the reader pool should be pulled out of IndexWriter, be externally provided, and be responsible for doing warming of new segments.
---
Migrated from [LUCENE-2485](https://issues.apache.org/jira/browse/LUCENE-2485) by Michael McCandless (@mikemccand), updated May 09 2016
Contributor guide
Research direction
Start by tracing IndexWriter's mergedSegmentWarmer handling and the reader pool path for newly merged segments. Compare how flushed and merged segments are warmed; done would require a decided scope covering flushed segments, the proposed setSegmentWarmer rename, and whether reader-pool ownership should move outside IndexWriter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, search
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 20/100