apache / apache/lucene

debug what happened with 14031

Open
#14,042 6 comments 2 reactions 0 assignees View on GitHub
type:task
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

### Description

PR #14031 makes the float vector functions inlinable, but caused a drop in nightly benchmark.
We reverted the PR in #14041 , but we should try to figure it out, as we don't want unpredictable performance.

Maybe the problem is specific to AMD and we should test that. Also it would be great if we could safely add some debugging to the nightly benchmark to understand what happens with the compilation (e.g. `-XX:+PrintCompilation` or `-XX:+LogCompilation`).

Contributor guide

Open the contributing guide

Research direction

Start by comparing PR #14031 with its revert in PR #14041 and reviewing the nightly benchmark results that showed the regression. Test whether the effect is specific to AMD and investigate compilation with -XX:+PrintCompilation or -XX:+LogCompilation. Done means identifying the cause and establishing a safe way to collect the needed benchmark diagnostics.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.