apache / apache/lucene

Remove all deprecated IndexSearcher#search(Query, Collector) usage / methods in the next major release

Open
#12,892 5 comments 0 reactions 1 assignee Claimed by @javanna View on GitHub
affects-version:10.0 type:task
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

### Description

As a follow-up of https://github.com/apache/lucene/issues/11041, we would like to remove all deprecated `IndexSearcher#search(Query, Collector)` methods in the next major release, preferably `10.0.0`.

A list of the leftover usages follows:

- [x] facet: FacetsCollector (ongoing discussion at #13725, PR at #13733)
- [x] facet.test: TestTaxonomyFacetAssociations (PR at #13726)
- [x] grouping: GroupingSearch (#15936 , #16247)
- [x] grouping.test: BaseGroupSelectorTestCase
- [x] grouping.test: TestAllGroupHeadsCollector (#15565)
- [x] grouping.test: TestAllGroupsCollector (#15557)
- [x] grouping.test: TestDistinctValuesCollector (#16217)
- [ ] grouping.test: TestGroupFacetCollector (#16292)
- [x] grouping.test: TestGrouping (#16247, #16379)
- [ ] join: JoinUtil (PR at #13747, #16091)
- [x] join.test: TestJoinUtil (#16262)
- [x] monitor: CollectingMatcher (PR at #13735)
- [x] monitor remaining usages (#16197)
- [x] test-framework: QueryUtils (#16266)
- [x] misc.test: TestDiversifiedTopDocsCollector (#16216)
- [x] misc.test: TestDocValuesStatsCollector
- [x] misc.test: TestMemoryAccountingBitsetCollector
- [x] sandbox.test: TestLargeNumHitsTopDocsCollector
- [x] sandbox.test: TestProfilerCollector (PR at #13746)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.