apache / apache/lucene

Wrong autocomplete suggestion [LUCENE-10645]

Open
#11,681 3 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

I have problem with autocomplete suggestion (I use your test to show you where is the bug ).

This is your test and everything works fine:

public void testBothExactAndPrefix() throws Exception

{     Analyzer a = new MockAnalyzer(random(), MockTokenizer.WHITESPACE, false);     AnalyzingInfixSuggester suggester = new AnalyzingInfixSuggester(newDirectory(), a, a, 3, false);     suggester.build(new InputArrayIterator(new Input[0]));     suggester.add(new BytesRef("the pen is pretty"), null, 10, new BytesRef("foobaz"));     suggester.refresh();     List<LookupResult> results =         suggester.lookup(TestUtil.stringToCharSequence("pen p", random()), 10, true, true);     assertEquals(1, results.size());     assertEquals("the pen is pretty", results.get(0).key);     assertEquals("the <b>pen</b> is <b>p</b>retty", results.get(0).highlightKey);     assertEquals(10, results.get(0).value);     assertEquals(new BytesRef("foobaz"), results.get(0).payload);     suggester.close();     a.close();  }

 

But if I add this row to the test {**}suggester.add(new BytesRef("the pen is fretty"), null, 10, new BytesRef("foobaz")){**}, the test goes wrong.

public void testBothExactAndPrefix() throws Exception

{   Analyzer a = new MockAnalyzer(random(), MockTokenizer.WHITESPACE, false);   AnalyzingInfixSuggester suggester = new AnalyzingInfixSuggester(newDirectory(), a, a, 3, false);   suggester.build(new InputArrayIterator(new Input[0]));   suggester.add(new BytesRef("the pen is pretty"), null, 10, new BytesRef("foobaz"));   **suggester.add(new BytesRef("the pen is fretty"), null, 10, new BytesRef("foobaz"));**   suggester.refresh();   List<LookupResult> results =       suggester.lookup(TestUtil.stringToCharSequence("pen p", random()), 10, true, true);   assertEquals(1, results.size());   assertEquals("the pen is pretty", results.get(0).key);   assertEquals("the <b>pen</b> is <b>p</b>retty", results.get(0).highlightKey);   assertEquals(10, results.get(0).value);   assertEquals(new BytesRef("foobaz"), results.get(0).payload);   suggester.close();   a.close(); }

We want to find everything that contains "pen p" and we have just one matcher "the pen is pretty", but in the results we have two matches "the pen is pretty" and "the pen is fretty".

I think when we want to find some words - in this study "pen" and the second word with one letter, which is the same as the first letter in our word - in this study "p", the suggester first match word "pen" and then match "p" in "pen", which is inccorect. We want to match "p" in a word other than "pen".

---
Migrated from [LUCENE-10645](https://issues.apache.org/jira/browse/LUCENE-10645) by Emiliyan Sinigerov, updated Jul 11 2022

Contributor guide

Open the contributing guide

Research direction

Start with lucene/suggest/src/test/org/apache/lucene/search/suggest/analyzing/TestAnalyzingInfixSuggester.java and reproduce testBothExactAndPrefix with both "pretty" and "fretty" entries. Trace the AnalyzingInfixSuggester lookup for "pen p" and compare the returned matches with the test's expected single result. Done means the lookup returns only the intended suggestion while preserving its highlighting, value, and payload.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.