apache / apache/lucene

DisjunctionMaxWeight could be rewrite to BooleanWeight if score is disable [LUCENE-10537]

Open
#11,573 2 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Minor type:enhancement
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

If scores are not needed, could we let BooleanWeight deal with optimizing things?

---
Migrated from [LUCENE-10537](https://issues.apache.org/jira/browse/LUCENE-10537) by Lu Xugang (@LuXugang), updated May 04 2022
Pull requests: https://github.com/apache/lucene/pull/839

Contributor guide

Open the contributing guide

Research direction

Start by tracing DisjunctionMaxWeight and BooleanWeight, focusing on behavior when scores are disabled. Review the existing tests covering these weights and determine whether the score-disabled path can safely use BooleanWeight's optimizations. Done means the intended delegation works without changing scored behavior and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.