apache / apache/lucene

Advance conjunction Iterator for two phase iteration [LUCENE-9555]

Open
#10,594 2 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Minor type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

#10320 introduced a sort optimization where
documents can be skipped.
But there was a bug in case we were using two phase
approximation, as we would advance it without advancing
an overall conjunction iterator.

Relates to #10320

---
Migrated from [LUCENE-9555](https://issues.apache.org/jira/browse/LUCENE-9555) by Mayya Sharipova (@mayya-sharipova), updated Oct 06 2020
Pull requests: https://github.com/apache/lucene-solr/pull/1943

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the sort optimization introduced in #10320 and the linked pull request 1943, then trace how two-phase approximation advances the overall conjunction iterator. Done means documents can be skipped without leaving the conjunction iterator out of sync during two-phase iteration.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.