apache / apache/lucene

Point2D#withinTriangle logic is wrong [LUCENE-9197]

Open
#10,237 2 comments 0 reactions 0 assignees View on GitHub
legacy-jira-priority:Major type:bug
Dominant language
Java
Stars
3.6k
Forks
1.4k
Avg merge
2d 11h
Merged PRs (30d)
88

Description

The current logic is wrong and needs to be properly implemented

---
Migrated from [LUCENE-9197](https://issues.apache.org/jira/browse/LUCENE-9197) by Ignacio Vera (@iverase), updated Feb 04 2020

Contributor guide

Open the contributing guide

Research direction

Start by locating and reading `Point2D#withinTriangle`, then review the linked LUCENE-9197 issue for the intended behavior. The issue gives no expected result or test location, so establish the correct triangle-membership behavior before identifying tests that can confirm the fix.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.