apache / apache/logging-log4j2

Replace `@NameProvider` and `@AliasesProvider` registration of strategies in `ConfigurableInstanceFactory`

Open
#3,870 5 comments 0 reactions 1 assignee Claimed by @jvz View on GitHub
graalvm plugins
Dominant language
Java
Stars
3.6k
Forks
1.7k
Avg merge
21h 30m
Merged PRs (30d)
27

Description

During the 3.x DI system overhaul, one major change made to most of the plugin annotations was migrating the strategy code for interpreting annotations. Previously, it would be specified via plugin visitor classes, and the annotation would be meta-annotated to mark the strategy class to use. This is excess implementation detail that leaks into the annotations of plugins, and that already raised issues in the past when `log4j-plugins` had to be separated from `log4j-core` in order for the annotation processor to work in a modular environment.

The SPI to replace this should allow for registering strategies on how to extract a qualifier name and aliases from an injection point. The resulting plugin annotations should therefore no longer be meta-annotated with implementation details.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.