apache / apache/logging-log4j2

AsyncLogger does not compute location for some methods

Open
#1,458 0 comments 0 reactions 0 assignees View on GitHub
async bug
Dominant language
Java
Stars
3.6k
Forks
1.7k
Avg merge
21h 30m
Merged PRs (30d)
27

Description

## Description

A logging call that is not filtered out will eventually call one of these methods:

* [`AbstractLogger#log(Level, Marker, String, StackTraceElement, Message, Throwable)`](https://logging.apache.org/log4j/2.x/log4j-api/apidocs/org/apache/logging/log4j/spi/AbstractLogger.html#log-org.apache.logging.log4j.Level-org.apache.logging.log4j.Marker-java.lang.String-java.lang.StackTraceElement-org.apache.logging.log4j.message.Message-java.lang.Throwable-),
* [`Logger#logMessage(Level, Marker, String, StackTraceElement, Message, Throwable)`](https://logging.apache.org/log4j/2.x/log4j-api/apidocs/org/apache/logging/log4j/Logger.html#logMessage-org.apache.logging.log4j.Level-org.apache.logging.log4j.Marker-java.lang.String-java.lang.StackTraceElement-org.apache.logging.log4j.message.Message-java.lang.Throwable-): effectively a `final` method, a recursion-safe version of the previous one,
* [`ExtendedLogger#logMessage(String, Level, Marker, Message, Throwable)`](https://logging.apache.org/log4j/2.x/log4j-api/apidocs/org/apache/logging/log4j/spi/ExtendedLogger.html#logMessage-java.lang.String-org.apache.logging.log4j.Level-org.apache.logging.log4j.Marker-org.apache.logging.log4j.message.Message-java.lang.Throwable-).

`AsyncLogger` correctly computes the location, if the third method is called. If the first method is called with `location == null` no attempt to compute location occurs.

## Configuration

**Version:** 2.20.0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.