apache / apache/libcloud

DigitalOcean will change their floating IP API on the 26th of april

Open
#1,574 1 comment 0 reactions 0 assignees View on GitHub
api: compute drivers: digitalocean stale
Dominant language
Python
Stars
2.1k
Forks
931
Avg merge
1d 2h
Merged PRs (30d)
4

Description

We just got an email from DigitalOcean stating that they will change their [Floating IP API endpoint](https://developers.digitalocean.com/documentation/v2/#floating-ips) starting the 26th. Functionally this shouldn't break in libcloud but the fixtures for the tests that are used will be a bit outdated (https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/digitalocean_v2/list_floating_ips.json)

Changes announced by DigitalOcean:
```
The `private_networking` feature will now be listed under droplet.features instead of region.features
vpc_uuid was not being populated and will have the correct values now
The droplet.type will be "base" when the droplet is a base image (i.e. Ubuntu, CentOS).
The current value is "snapshot"
The Droplet's networking field will include any private IPs and any floating IPs which are missing from the response today
```

Test fixtures that would become 'inaccurate':
https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/digitalocean_v2/list_floating_ips.json
https://github.com/apache/libcloud/blob/trunk/libcloud/test/compute/fixtures/digitalocean_v2/create_floating_ip.json

Contributor guide

Open the contributing guide

Research direction

Start by reviewing libcloud/test/compute/fixtures/digitalocean_v2/list_floating_ips.json and create_floating_ip.json alongside the DigitalOcean compute tests that consume them. Compare the fixtures with the announced Floating IP API response changes, then run the relevant tests and confirm the fixtures represent the updated response fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cloud
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.