apache / apache/libcloud

RecordType.URL should be RecordType.URI

Open
#1,523 1 comment 0 reactions 0 assignees View on GitHub
stale
Dominant language
Python
Stars
2.1k
Forks
931
Avg merge
1d 2h
Merged PRs (30d)
4

Description

## Summary

`libcloud.dns.types` defines a RecordType 'URL'. However, no such RR Type exists in DNS. Likely, this is supposed to refer to the 'URI' RR Type.

## Detailed Information

The authoritative list of DNS RR types is https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml. There is no 'URL' RR type in this list. There is a 'URI' RR type in this list, as defined in [RFC 7553](https://tools.ietf.org/html/rfc7553)

This RecordType is defined in 4 places in libcloud:

[libcloud.dns.types, line 112](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/types.py#L112):
```
URL = 'URL'
```

[libcloud.dns.drivers.cloudflare, line 171](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/cloudflare.py#L171): [sic!]
```
RecordType.URL: 'LOC'
```
According to the [Cloudflare API documentation](https://api.cloudflare.com/#dns-records-for-a-zone-create-dns-record), the correct name should indeed be `'URI'`.

[libcloud.dns.drivers.dnsimple, line 57](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/dnsimple.py#L57)
```
RecordType.URL: 'URL',
```
This seems correct. [DNSsimple indeed has a proprietory URL record](https://support.dnsimple.com/articles/url-record/).

[`libcloud.dns.drivers.zerigo`, line 142](https://github.com/apache/libcloud/blob/trunk/libcloud/dns/drivers/zerigo.py#L142)
```
RecordType.URL: 'URL',
```
http://www.zerigo.com gives an error. I get the impression this API is no longer functional.

Suggested Resolution
-----------

~~My suggestion is to change these occurrences into `'URI'`~~
I stand corrected, DNSsimple does indeed has a proprietory URL record type. However, Cloudflare does not.
My suggestion is to either remove support for the URI RR type at Cloudflare (it will likely not have worked due to the incorrect `'LOC'` string), or to add support for the URI RR type next to the (unofficial) URL RR type.

I'm happy to create a PR once there is consensus about the best approach to fix this.

Contributor guide

Open the contributing guide

Research direction

Review libcloud/dns/types.py and the Cloudflare, DNSimple, and Zerigo driver mappings cited in the issue, then compare each provider's documented record types. Resolve the provider-specific URL versus URI behavior and correct the inconsistent Cloudflare mapping or supported record definitions; done means the mappings accurately reflect the cited provider APIs and DNS standards.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.