apache / apache/kyuubi

[FEATURE] `admin GET engine` and `admin DELETE engine` should support passing in Session configs

Open
#4,820 1 comment 0 reactions 0 assignees View on GitHub
kind:feature priority:major
Dominant language
Scala
Stars
2.4k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/kyuubi/issues?q=is%3Aissue) and found no similar issues.

### Describe the feature

This feature is only for the GROUP share level.

The function `primaryGroup` of `GroupProvider` has an argument `sessionConf` (https://github.com/apache/kyuubi/blob/master/extensions/server/kyuubi-server-plugin/src/main/java/org/apache/kyuubi/plugin/GroupProvider.java#L25) which supports users to config their group name in Kyuubi Session Config when creating a Kyuubi Session.

But the `admin get engine` and `admin delete engine` don't support users to pass in the configs, which might cause bugs for example the `GroupProvider` can't return the correct primary group.

### Motivation

_No response_

### Describe the solution

Add a new parameter `configs: Map` to `listEngines` and `deleteEngine` for users to pass the session configs.

### Additional context

_No response_

### Are you willing to submit PR?

- [X] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
- [ ] No. I cannot submit a PR at this time.

Contributor guide

Open the contributing guide

Research direction

Start with the GroupProvider.primaryGroup(sessionConf) definition linked in the issue, then trace the admin listEngines and deleteEngine entry points. Add support for passing session configurations for GROUP sharing and verify that the configured primary group is used correctly by both operations.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.