apache / apache/kyuubi

[Improvement] Make KyuubiThriftBinaryFrontendService handler thread pool daemon

Open
#3,242 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
2.4k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.

### What would you like to be improved?

Since the KyuubiThriftBinaryFrontendService thread is not a daemon, it will wait for the KyuubiThriftBinaryFrontendService handler thread to finish or time out, so we can make KyuubiThriftBinaryFrontendService handler thread daemon.

![image](https://user-images.githubusercontent.com/17894939/184846786-08021633-ce73-42c0-8d66-bd1660d4f51f.png)

FYI: org.apache.thrift.server.TThreadPoolServer#serve:
![image](https://user-images.githubusercontent.com/17894939/184848712-95221c74-e5d2-4641-bac6-3dbedb140fac.png)

### How should we improve?

_No response_

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Research direction

Start with KyuubiThriftBinaryFrontendService and the referenced org.apache.thrift.server.TThreadPoolServer#serve entry point to trace how handler threads are created. Confirm the service handler thread is daemonized and verify that shutdown no longer waits for it to finish or time out; no source file or test path is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.