apache / apache/kyuubi

[SUB-TASK][KPIP-2] Support Flink SQL Client startup options.

Open
#2,153 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
2.4k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

### Code of Conduct

- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)

### Search before asking

- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.

### What would you like to be improved?

The following issue only achieves `FlinkSQLEngine` process, but users have no way to set `--jar` and `--library` options in Kyuubi. We should achieve this in `KyuubiServer` process too.

https://github.com/apache/incubator-kyuubi/issues/1685
https://github.com/SteNicholas/incubator-kyuubi/commit/dd5a704342334feb24eae981d184943f618dd228

We can put `--jar` and `--library` options in `kyuuubi-default.conf`, and `KyuubiServer` process load these options.

### How should we improve?

`KyuubiServer` process loads the Flink `SQL Client startup options` in `kyuuubi-default.conf`. And then `KyuubiServer` transforms the options to standard Flink `SQL Client startup options` and passes them to `flink-sql-engine.sh` when the `flink-sql-engine.sh` process will be started.

The `kyuuubi-default.conf `options like the following.
```
flink.client.option.jar foo.jar
flink.client.option.library /foo/bar
```

Now `flink-sql-engine.sh` startup options are nothing, so users can't set any options.

### Are you willing to submit PR?

- [X] Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.