apache / apache/kvrocks

Consider only output to LOG instead of hardcoded stdout/stderr

Open
#662 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
4.4k
Forks
658
Avg merge
1d 20h
Merged PRs (30d)
10

Description

### Search before asking

- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.

### Motivation

Refer to https://github.com/apache/incubator-kvrocks/pull/660#issuecomment-1165637383.

It is good to keep kvrocks with only one output location.
But currently, kvrocks also outputs some information to stdout when logdir is set to a regular file, which can be confusing for users.

### Solution

_No response_

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the linked pull request comment and tracing how logdir set to a regular file is handled. Identify the paths that write to stdout or stderr instead of LOG, then define done as routing those messages to the single configured output location and verify the behavior with relevant logging tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend, observability-sre
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.