apache / apache/kvrocks

Add support of the DUMP with all data types

Open
#3,319 4 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
4.4k
Forks
658
Avg merge
1d 20h
Merged PRs (30d)
10

Description

### Search before asking

- [x] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.

### Motivation

Currently in kvrocks, `DUMP` command is supported in string, bitmap, hash, list, set, zset.
However it's not supported in other types. Basically in redis, it supports `DUMP` with all types.

e.g. dump bloom-filter type

**kvrocks**
```
127.0.0.1:6666> bf.reserve bfkey 0.01 100
OK
127.0.0.1:6666> dump bfkey
(error) ERR Invalid or Not supported object type
127.0.0.1:6666>
```

**Redis**
```
127.0.0.1:6379> bf.reserve bfkey 0.01 100
OK
127.0.0.1:6379> dump bfkey
"\a\x810\x16\xe5\xa2\x89\xbe\xf8\x04\x02\x00\x02\x01\x02\x05\x02\x02\x02@d\x04{\x14\xaeG\xe1zt?\x02\b\x04\xe9\x86/\xb25\x0e&@\x02D\x80\x02\x00\x05\xc3\t@\x90\x01\x00\x00\xe0\x83\x00\x01\x00\x00\x02\x00\x00\x0c\x007\x92(\xde\x13H\xb8\xac"
127.0.0.1:6379>
```

### Solution

Add to support `DUMP` with all types which implemented in kvrocks.
- [X] SortedInt https://github.com/apache/kvrocks/pull/3366
- [ ] Stream
- [ ] BloomFilter
- [ ] Json
- [ ] HyperLogLog
- [ ] TDigest
- [ ] TimeSeries

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the existing DUMP command support for strings, bitmaps, hashes, lists, sets, zsets, and SortedInt, then compare how the remaining implemented types are represented. Work through the checklist for Stream, BloomFilter, Json, HyperLogLog, TDigest, and TimeSeries, and verify that DUMP succeeds for each type as it does in Redis.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.