apache / apache/kvrocks

TDigest: use rocksdb iterator for centroids iteration.

Open
#2,789 1 comment 0 reactions 1 assignee Claimed by @LindaSummer View on GitHub
enhancement
Dominant language
C++
Stars
4.4k
Forks
658
Avg merge
1d 20h
Merged PRs (30d)
10

Description

### Search before asking

- [x] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.

### Motivation

# Related Issue
#2558

In TDigest implementation #2741 , we use `DummyCentroids` to achieve a simple iteration and it should be refactored to rocksdb native iterator as designed.

https://github.com/apache/kvrocks/pull/2741#discussion_r1950452348

### Solution

- Implement a `RocksdbCentroids` and replace the `DummyCentroids`.
- Add more unit tests for encoding, decoding and algorithm.

### Are you willing to submit a PR?

- [x] I'm willing to submit a PR!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.