apache / apache/kvrocks

Add support for Xcode

Open
#2,283 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
4.4k
Forks
658
Avg merge
1d 20h
Merged PRs (30d)
10

Description

### Search before asking

- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.

### Motivation

In [CMakeLists.txt](https://github.com/apache/kvrocks/blob/1834ce81823fb5fa1442c24b9d7a84f950438124/CMakeLists.txt#L60), `if(CMAKE_GENERATOR STREQUAL "Ninja")` is applicable to Xcode as well.

### Solution

`if(CMAKE_GENERATOR STREQUAL Ninja OR CMAKE_GENERATOR STREQUAL Xcode)`

### Are you willing to submit a PR?

- [ ] I'm willing to submit a PR!

Contributor guide

No contributing guide indexed for this repository

Research direction

Open CMakeLists.txt around line 60 and inspect the CMAKE_GENERATOR check. Compare its handling of the Ninja and Xcode generators, then configure the project with the Xcode generator to verify that support works as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.