Enable CompactionChecker for "search" CF
- Dominant language
- C++
- Stars
- 4.4k
- Forks
- 658
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 10
Description
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/kvrocks/issues) and found no similar issues.
### Motivation
https://github.com/apache/kvrocks/blob/899216db7316083b5de9cef03dd0e818ededed96/src/server/server.cc#L200-L201
Should we enable compaction checker in this checking?
### Solution
```
std::vector cf_names = {engine::kMetadataColumnFamilyName, engine::kSubkeyColumnFamilyName,
engine::kZSetScoreColumnFamilyName, engine::kStreamColumnFamilyName};
for (const auto &cf_name : cf_names) {
compaction_checker.PickCompactionFiles(cf_name);
}
```
Add type in this list
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
Contributor guide
No contributing guide indexed for this repository
Research direction
Open src/server/server.cc around lines 200-201 and inspect how CompactionChecker selects column families. Add the search column-family type to the existing list, then verify that the compaction check includes it without changing the other entries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- database
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100