apache / apache/jmeter

Undesirable change to JDBC Sampler behaviour in 5.6.3

Open
#6,345 2 comments 0 reactions 0 assignees View on GitHub
defect to-triage
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

### Expected behavior

The following commit has introduced an undesirable change to the JDBC sampler.

https://github.com/apache/jmeter/commit/945281cfaa6cca782f0e11f151eb22497d545713

Prior to this change, the "Limit Resultset" value would only apply when reading the result set, reading would stop after 'n' rows.

Now, by this change, the sampler calls SetMaxRows() to the limit value. This can then be used by the JDBC client and server to optimise the query, such as by pushing a LIMIT clause into the query plan which can terminate server processing before all results have been generated.

I believe this behaviour should be rolled back, as it invalidates a common requirement of database performance testing.

### Actual behavior

_No response_

### Steps to reproduce the problem

https://github.com/apache/jmeter/commit/945281cfaa6cca782f0e11f151eb22497d545713

### JMeter Version

5.6.3

### Java Version

_No response_

### OS Version

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.