apache / apache/jmeter

Deprecate ValueTransformer as it exposes masterFunction and variables properties

Open
#5,948 0 comments 0 reactions 0 assignees View on GitHub
enhancement to-triage
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

### Use case

Currently, `ReplaceStringWithFunctions` is hard to use, and it is hard to understand.
The class requires `masterFunction` and `variables`, however, it does not really use the variables.

### Possible solution

`ReplaceStringWithFunctions` was public for a long time already, and somebody might even created a subclass or passed a custom `CompoundVariable`, so I suggest deprecate all the old classes implementing `ValueTransformer` and add a new interface `ValueTransformer2` that will have just the transformation method.

### Possible workarounds

_No response_

### JMeter Version

5.5

### Java Version

_No response_

### OS Version

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.