apache / apache/jmeter

DefaultSamplerCreator gives inaccurate log message saying "setting path ... " after already set the path

Open
#5,668 0 comments 0 reactions 0 assignees View on GitHub
os: All P2
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

**Ding Ding** ([Bug 66061](https://bz.apache.org/bugzilla//show_bug.cgi?id=66061&redirect=false)):
Hello,

While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I found that the logging statements might give inaccurate messages.

I also found that the in the line 420 of the file DefaultSamplerCreator.java, the log messages says "setting path...". However, the path should already be set in previous lines of code.

Would it be better if we change the verb "setting" to "have set" to indicate the action is completed? Or can we move the logging statement to the begining of the method? Since when there was an exception in previous lines, the logging message would not be printed, which may be not good for debugging.

The detailed url is:
https://github.com/apache/jmeter/blob/659c1ff5eaea941eb7ad0638b58e904dcc06d961/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java/#L420

Severity: trivial
OS: All

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.