apache / apache/jmeter

Comments section improvements for all tree pane elements

Open
#5,462 3 comments 0 reactions 0 assignees View on GitHub
need info os: All P2
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

**eR@SeR** ([Bug 65012](https://bz.apache.org/bugzilla//show_bug.cgi?id=65012&redirect=false)):
Hello,

If for some reason, text in the comment section is quite huge, when navigating to the commented element, IMO, the view is not expected. Please check the provided jmx as an example:

1. If clicked on VRT 1 element (one-line text in Comments), view (horizontal scroll bar) focuses the last character of the text.

The expected view could be like there is no comment at all i.e. horizontal scroll bar at the bottom is scrolled completely to the left.
----
2. If clicked on VRT 1 element, then mouse hover on any text box and use mouse wheel up several times, horizontal scroll bar moves slightly to the left.

The expected amount of lines to scroll could be the same as in the tree pane (expand Simple controller and use mouse wheel down/up several times to see the difference).
----
3. If clicked on VRT 1 element, then on the comment text box and pressed Home or Page Up button, the horizontal scroll bar is moved to the beginning of the text box.

The expected view could be that the horizontal scroll bar is scrolled completely to the left (to display initial view - like when used Ctrl+Page Up). If End or Page Down button is pressed, the horizontal scroll bar could be moved completely to the right (like when used Ctrl+Page Down).
----
4. If VRT 1 element is duplicated (Ctrl+Shift+C) and then the text from VRT 2 is completely copied and pasted to VRT 1 comment text box, overwriting whole text in it, comment text box is not expanded completely to the bottom (like it should), to show the last line of text. Check "VRT 1 Duplicated" image in next comment.
----
5. If clicked on VRT 3 element and used mouse wheel up/down several times, vertical scroll bar moves slightly up/down.

The expected amount of lines to scroll could be the same when mouse wheel up/down is used in the tree pane.
----
6. If clicked on VRT 3 element, then on the comment text box and pressed Ctrl+Home or Page Up button, the horizontal scroll bar is moved to the beginning of text box.

The expected view could be that the horizontal scroll bar is scrolled completely to the left (to display the initial view). If End or Page Down button is pressed, the horizontal scroll bar could be moved completely to the right.
----
Generally speaking, if clicked on any of 4 VRT listeners, the default view could be the initial one, same like there is no text inside the comments text box i.e. horizontal scroll bar is complete to the left and vertical to the top if there are multiple lines of text. Some of the expected results might differ from the regular behavior of the text box, so misinterpretations are possible - sorry for that. The goal is to make Comments section behavior better.

Particularly, I have stored a lot of SQLs in some tests and current behavior reduces UX. Maybe "Word wrap" checkbox option could solve most of the reported issues. Or fix reported ones and add Word wrap option as well. Whatever is done, I'm will test the changes.

Jmeter 5.4.1 54e820e
Microsoft Windows 10 Pro 64-bit
java version "1.8.0_251"

Created attachment [commentSectionImprovement.jmx](https://apache.github.io/jmeter-bugzilla-attachments/12/65012/37631/commentSectionImprovement.jmx): commentSectionImprovement.jmx

Version: Nightly
Severity: normal
OS: All

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.