apache / apache/jmeter

__groovy function seems to have useless synchronized in execute

Open
#4,687 4 comments 0 reactions 0 assignees View on GitHub
enhancement os: All P2
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

@pmouawad ([Bug 62082](https://bz.apache.org/bugzilla//show_bug.cgi?id=62082&redirect=false)):
Following same analysis of https://github.com/apache/jmeter/issues/3460 and as per understanding of this:

- https://stackoverflow.com/questions/48644849/is-groovy-scriptingengine-thread-safe

Groovy ScriptEngine "THREADING" is equal to MULTITHREADED:
- https://docs.oracle.com/javase/8/docs/api/javax/script/ScriptEngineFactory.html#getParameter-java.lang.String-

It seems we could avoid the synchronized block.

Thoughts ?
Thanks

OS: All

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.