apache / apache/jmeter

SavePropertyDialog.setSaveConfig/getSaveConfig not used; should be removed

Open
#3,905 0 comments 0 reactions 0 assignees View on GitHub
enhancement os: macOS P2
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

**Sebb** ([Bug 59185](https://bz.apache.org/bugzilla//show_bug.cgi?id=59185&redirect=false)):
The SavePropertyDialog class is currently only used by AbstractVisualizer.

It seems unlikely it will be needed anywhere else, and anyway the get/set methods for the saveConfig field don't really make sense. The config is passed in via the constructor.

If the setter were dropped, the field could be made final.

Not much point having a getter either as the field is provided by the caller.

OS: Mac OS X 10.1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.