apache / apache/jmeter

Eliminate JmeterKeyStore and simplify code

Open
#2,636 3 comments 0 reactions 0 assignees View on GitHub
enhancement os: Windows P2
Dominant language
Java
Stars
9.5k
Forks
2.3k
Avg merge
1d 22h
Merged PRs (30d)
5

Description

**Sebb** ([Bug 52131](https://bz.apache.org/bugzilla//show_bug.cgi?id=52131&redirect=false)):
The JmeterKeyStore class is not really needed any more, and could be dropped in favour of DefaultKeyStore.

This would then allow the ctor to be extended to include the indexes, which could then be final variables.

Alternatively, merge DefaultKeyStore into JmeterKeyStore and make that class concrete. That would probably mean fewer changes.

Thoughts?

OS: Windows XP

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.